Skip to content

Add Ruby lockfiles and remove them from gitignore - #206

Merged
olaservo merged 1 commit into
modelcontextprotocol:mainfrom
a-akimov:chore/ruby-lock-gitignore
Sep 22, 2026
Merged

olaservo merged 1 commit into
modelcontextprotocol:mainfrom
a-akimov:chore/ruby-lock-gitignore

Conversation

@a-akimov

Copy link
Copy Markdown
Contributor

Motivation and Context

Lockfiles provide stable output and are already used for other tutorials. Let's remove them from .gitignore and use in Ruby examples too.

These lockfiles were generated with versions used in #204, so this PR needs to be merged after 204.

How Has This Been Tested?

Locally.

Breaking Changes

N/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

N/a

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

All reviewed changes are ready for approval.

Review effort: Lite
Findings: None

What changed in this PR

Adds committed Ruby Bundler lockfiles and stops ignoring Gemfile.lock files.

Changes:

  • Adds lockfiles for the Ruby client and weather server.
  • Removes the global lockfile ignore rule.
  • Clarifies the Bundler helper comment.
File Summary
weather-server-ruby/​Gemfile.lock Locks server dependencies.
tests/​utils.sh Updates Bundler helper documentation.
mcp-client-ruby/​Gemfile.lock Locks client dependencies.
.gitignore Allows lockfiles to be tracked.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@olaservo
olaservo merged commit a2bdc36 into modelcontextprotocol:main Sep 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants