fix: preserve configured reqwest client#917
Merged
Merged
Conversation
2c5e93a to
c6ce6f5
Compare
c6ce6f5 to
6b27456
Compare
alexhancock
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Following up on PR #908, this fixes a regression from the OAuth HTTP client adapter change where
AuthorizationManager::with_clientno longer preserved the caller-provided reqwest configuration for token operations. Existing users ofwith_client(reqwest::Client)expect their proxy, TLS, connector, timeout, and default-header settings to apply across OAuth requests, including authorization-code exchange.The regression happened because the adapter kept the configured reqwest client for redirect-following requests, but built a separate default client for
OAuthHttpRedirectPolicy::Stop. That preserved the new no-redirect intent for token requests, but it also dropped any caller-provided reqwest configuration on those requests.This fix preserves the legacy
with_clientcontract by using the configured reqwest client for both redirect policies on that path, while leaving the newerOAuthHttpClientpath available for callers that need stricter redirect handling.How Has This Been Tested?
Added regression tests
Breaking Changes
None.
Types of changes
Checklist