fix(everything): drop disconnected session from subscriptions map - #4718
Open
AbhiPra24 wants to merge 1 commit into
Open
fix(everything): drop disconnected session from subscriptions map#4718AbhiPra24 wants to merge 1 commit into
AbhiPra24 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4710
When a client session closes or disconnects, its session ID remained in the
subscriptionsmap indefinitely. This patch introducescleanupSubscriptions(sessionId)to remove the disconnected session from tracked URI subscriptions (and prune empty URIs from the map) and invokes it during server cleanup (cleanup(sessionId)). Also cleans up empty subscriber sets on explicit unsubscribe requests.Changes
src/everything/resources/subscriptions.ts: AddedcleanupSubscriptionsto remove all subscriptions for a session ID and delete empty URI entries; deleted empty URI sets inUnsubscribeRequestSchemahandler; exportedgetSubscriptionsfor inspection/testing.src/everything/server/index.ts: AddedcleanupSubscriptions(sessionId)tocleanupcallback returned bycreateServer.src/everything/__tests__/resources.test.tsandsrc/everything/__tests__/server.test.tsto verify session subscription cleanup on disconnect.Verification
npm --workspace=@modelcontextprotocol/server-everything testpassed (108 tests passing).npm run buildpassed.