Further clarify parameter and evaluable for synchronous.#3839
Merged
HansOlsson merged 2 commits intomodelica:masterfrom Mar 12, 2026
Merged
Further clarify parameter and evaluable for synchronous.#3839HansOlsson merged 2 commits intomodelica:masterfrom
HansOlsson merged 2 commits intomodelica:masterfrom
Conversation
Clarification triggered by modelica#3811 - but not part of original text.
HansOlsson
added
clocked
HansOlsson
commented
Mar 5, 2026
Not needed
henrikt-ma
approved these changes
Mar 10, 2026
Collaborator
henrikt-ma
left a comment
henrikt-ma
left a comment
There was a problem hiding this comment.
The change seems small and safe, so even though it would be nice with a review by an expert on this chapter, I am providing an approval in case no expert shows up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarification triggered by #3811 - but not part of original text.
Note that there's one special case that I haven't included, as I couldn't find a good text for it.
The special case is if the interval is zero for a non-evaluated rational clock - to me that should be handled as if it were a non-parameter expression that is zero, i.e., just an error, as it was intended to be inferred but there was nothing to infer it from.