Skip to content

[bugfix] avoid recomputing Flash-decode RoPE cache #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taking-lying-flat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[bugfix] avoid recomputing Flash-decode RoPE cache #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/mcore_bridge/model/gpt_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,11 @@ def _get_rotary_pos_emb(self, decoder_input, position_ids, packed_seq_params, in
assert (inference_context.is_static_batching()
), 'GPTModel currently only supports static inference batching.'
# Flash decoding uses precomputed cos and sin for RoPE
rotary_pos_cos, rotary_pos_sin = self.rotary_pos_emb_cache.setdefault(
inference_context.max_sequence_length,
self.rotary_pos_emb.get_cos_sin(inference_context.max_sequence_length),
)
max_sequence_length = inference_context.max_sequence_length
if max_sequence_length not in self.rotary_pos_emb_cache:
self.rotary_pos_emb_cache[max_sequence_length] = self.rotary_pos_emb.get_cos_sin(
max_sequence_length)
rotary_pos_cos, rotary_pos_sin = self.rotary_pos_emb_cache[max_sequence_length]
else:
rotary_seq_len = RotaryEmbedding.get_rotary_seq_len(self, inference_context, self.decoder,
decoder_input, self.config, packed_seq_params)
Expand Down
Loading