Mdk 456: Auth'd MCP Tools #13
Conversation
Add separate mcpContract namespace for MCP tools: - customers: list, get, create, update, delete - products: list, get, create, update, delete - orders: list, get (read-only) - checkouts: list, get (read-only) Export mcpContract from index.ts alongside SDK contract. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Organize imports alphabetically - Use Number.isNaN instead of global isNaN - Format multi-line exports Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@codex review please |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex please review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2aededc029
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- Use OrderStatusSchema instead of z.string() for status field - Use CurrencySchema instead of z.string() for currency field - Export OrderStatusSchema and OrderStatus type for consumers This ensures the contract validates against known enum values rather than accepting arbitrary strings, preventing silent acceptance of invalid values. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@codex check again please |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da5159882d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…erval - Rename RecurringIntervalWithNeverSchema → RecurringIntervalInputSchema - Export RecurringIntervalInputSchema and RecurringIntervalInput type - Document that server normalizes "NEVER" to null when storing/returning Input accepts "NEVER" for one-time products, output uses null. Server-side normalization ensures contract consistency. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@codex one more check please |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Add schemas and contracts for mcp API