You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was trying to fix https://rt.cpan.org/Ticket/Display.html?id=119534. This doesn't fix it, but I think these changes are still worth making. AFAICT, Sub::Defer really wants us to pass in a sub name.
The test failures are a bit confusing. The "changes doesn't have content" failure is sort of a false failure, since the Changes files doesn't have a listing for this version yet, right? But somehow it is still checking for release notes for 0.50. My EnsureChangesHasContent plugin would get this right, I think ;)
The 12_wrapper-definition.t failure is very confusing. It's some sort of heisenfailure. I can reproduce it by running the code multiple times. I think it might have to do with the fact that the test code uses ->can to get a coderef to the to_X sub. Then Sub::Defer replaces that sub by name, but the coderef itself still points to the old deferred sub. I don't understand why it sometimes works though.
Actually, I think the 12 failure is something else, where the use of Sub::Defer simply doesn't work properly with the wrapper functionality, but somehow it accidentally works in some cases. I could use some help from someone who understands the internals of MX::Types a little better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to fix https://rt.cpan.org/Ticket/Display.html?id=119534. This doesn't fix it, but I think these changes are still worth making. AFAICT, Sub::Defer really wants us to pass in a sub name.