Bug 1830760 - For manifests selected with very high confidence (e.g. manifests with modified tests), run on all configs#6035
Merged
Conversation
…manifests with modified tests), run on all configs
suhaibmujahid
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally we'd be smarted and e.g. run a modified tests only on all configs where the test actually runs, but I think this is still better than the current state.
The current algorithm uses history about previous failures, so if a test failed in the same way e.g. on Linux and Windows, it knows it can schedule on each independently. When a test or manifest is modified though, this assumption breaks because the failure mode could change.