Fix outdated ingestion pipeline docs#903
Merged
Merged
Conversation
The Decoded topic is read by the Kubernetes Live Sink (part of the ingestion-sink service on GKE), not a Dataflow job. Update the prose and relabel the diagram node accordingly. Also drop the inaccurate 'guaranteed to contain a few days of history' caveat: live tables are for low-latency access to recent data, not a supported analysis interface. Point readers to the stable tables instead.
The Raw topic is read by the Kubernetes Raw Sink (part of the ingestion-sink
service), not a Dataflow job, and writes to the payload_bytes_raw dataset. The
'Landfill' name is historical. Update the prose and relabel the diagram nodes;
keep a parenthetical for the old name. Match gcp-ingestion's own terminology
('Kubernetes Raw Sink job') rather than the stale 'custom Java application'
phrasing from a 2020 transition note.
Verified against gcp-ingestion ingestion-edge (create_app.py, publish.py, util.py, dockerflow.py): - GET /status does not exist. Health is served via Dockerflow endpoints (/__lbheartbeat__, /__heartbeat__, /__version__). Rewrite the GET request and response-code sections accordingly. - The ?v=4 query parameter is not validated or rejected at the edge; the edge routes on path only and forwards the body opaquely. Describe the actual behavior. - POST/PUT response codes: add 431 (attribute exceeds PubSub's 1024-byte limit) and 507 (local retry queue full), which the edge actually returns; drop 411 and 414, which are not enforced. - Define the previously dangling [decoder] and [schemas repository] reference-style links.
Verified against gcp-ingestion: ingestion-beam's PubsubMessageToTableRow is now a thin wrapper that adds Beam metrics and converts to a BigQuery TableRow; the transformation logic (map types, nested arrays, tuples, coercion, additional_properties) moved to ingestion-core's PubsubMessageToObjectNode. Point the doc there and fix the 'Thee'/'telemtry' typos in the paragraph.
akkomar
changed the title
akkomar
enabled auto-merge (squash)
July 20, 2026 14:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects outdated statements in the ingestion pipeline docs, found by cross-checking each doc against the current implementation in https://github.com/mozilla/gcp-ingestion and IaC repos.