Enable historyUpdateUrl for local files #20484
Open
+43
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enables the historyUpdateUrl preference to work with local PDF files (file:// protocol), allowing the browser to remember and restore the last viewed position when the preference is enabled.
Problem:
Currently, the historyUpdateUrl preference only updates the URL hash for web-based PDFs. Local PDF files are explicitly excluded from this feature, even when the user has enabled the preference in about:config. This inconsistency means users cannot benefit from position restoration when viewing local files.
Solution:
Removed the protocol check that prevented file:// URLs from updating the browser history. The change is minimal and focused:
if (protocol !== "file:")condition in the#pushOrReplaceStatemethod#page=5) when scrolling, just like web-based PDFsTesting:
Related Issue:
Fixes : #20370
Note: This change only affects behavior when users explicitly enable pdfjs.historyUpdateUrl in Firefox preferences. The default behavior remains unchanged.