[test] Add an assertions mode to the axe regression harness - #48915
[test] Add an assertions mode to the axe regression harness#48915michelengelen wants to merge 1 commit into
assertions mode to the axe regression harness#48915Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
a5a6319 to
3da7a80
Compare
5dd3b74 to
ca61860
Compare
ca61860 to
91ee8d7
Compare
dc0eab5 to
e13e971
Compare
e13e971 to
fca727f
Compare
fca727f to
4475eb3
Compare
siriwatknp
left a comment
There was a problem hiding this comment.
👍 Thanks for splitting this out of #48708. The assertions refactor reads well — shouldAssert keeps the visual default exactly as before, and a11yRule cannot be undefined at the new call site.
A few things I found.
Lets a fixture assert every axe rule it exercises rather than only the CSS-dependent visual ones, which is what the per-component WCAG reports need.
4475eb3 to
a0b8a93
Compare
|
Thanks — this was a good catch on all counts. Everything is addressed; the branch is force-pushed.
Two further problems surfaced while fixing these, both mine:
The root cause of 2, 4, 5 and 7 is the same: I split the series mechanically and validated that each layer's tests pass and that the top of the stack was correct. Neither check catches a layer that deletes a passing test or carries a test for a component it does not touch. Reading each layer as a PR in its own right, which is what you did, is the check that was missing. Points 1 and 6 are not in the API response for this review — the numbering starts at 2. Did they get dropped before submitting? |
Adds an
assertionsmode to the axe regression harness so a fixture can assertevery axe rule it exercises, not only the CSS-dependent visual ones. This is the
foundation the per-component WCAG conformance reports build on.
Also stops excluding the
progressslug from the demo bundle so axe can reachthe LinearProgress demos; screenshots stay disabled slug-wide for it, since the
animated bars are flaky.
Original work by @mj12albert, extracted from #48708 so the harness change reviews
separately from the Button report.
Part of the WCAG conformance effort (see #14187).
Important
How to review this PR
Layer 1 of 14 in a stacked series (#48915 → #48926). Its branch is the base of the series. GitHub cannot chain PR bases across a fork, so every PR in the series targets
masterinstead.Its diff is exactly its own change —
a0b8a93.Part of the WCAG conformance effort (#14187).