Support moving note input cursor beyond score for more navigation commands#32433
Open
XiaoMigros wants to merge 3 commits intomusescore:masterfrom
Open
Support moving note input cursor beyond score for more navigation commands#32433XiaoMigros wants to merge 3 commits intomusescore:masterfrom
XiaoMigros wants to merge 3 commits intomusescore:masterfrom
Conversation
871a613 to
c28ce06
Compare
mathesoncalum
approved these changes
Mar 5, 2026
|
@XiaoMigros Looks good! I don't think this was caused by this PR, but I noticed that once I've moved the cursor to the area beyond the end of the score, the last thing in the last measure still looks selected. As a side effect, if the last thing is a note and I keep pressing right arrow or use the 'next measure'/'next system' shortcuts, the note preview plays on each press. Would it be possible to _NOT _ have the last element selected in this state? If this should be tackled in a different PR, do let me know and I can file an issue.
|
fcfdc00 to
ac734e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Currently only moving between chords (left/right arrow) is supported, this PR allows moving the cursor beyond the score when navigating between measures or systems as well.