Fix multiple clarinets sharing the same name in score.#32510
Draft
CubikingChill wants to merge 2 commits intomusescore:masterfrom
Draft
Fix multiple clarinets sharing the same name in score.#32510CubikingChill wants to merge 2 commits intomusescore:masterfrom
CubikingChill wants to merge 2 commits intomusescore:masterfrom
Conversation
df5425c to
0d3fe06
Compare
5a28fee to
342f27c
Compare
Contributor
Author
|
It appears that the value "TrackName" is used extensively, from mixer track name to "select instrument" page and "change instrument" in the score. Although the instrument name in these places should ideally be the same, it appears that they are not. Variant by key is specified in "select instrument" page but not the other 2. Seems we have to fix it by either specifying variant by key in all 3 fields, or simply use longName instead. Eitherway, this has been vary confusing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #32511 #23018