Map tremolo to the tremolo strings preset on single string instruments - #263
Map tremolo to the tremolo strings preset on single string instruments#263manolo wants to merge 1 commit into
Conversation
The section variants already select program 44 on their own bank, so a plain violin, viola, cello or double bass fell back to the arco sound.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAdded Merge Risk: ⚪ Minimal · up to The change routes tremolo articulations for four solo string instruments to their intended tremolo presets without adding new interfaces, dependencies, permissions, or deployment behavior. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes satisfy issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. Full details: Description checkExplanation The description identifies the issue, explains the technical change and motivation, references the replaced pull request, and completes the required checklist. The optional build configuration section is omitted without affecting completeness. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolves: musescore/MuseScore#21122
A tremolo on a solo violin, viola, cello or double bass plays the plain arco sound: the solo
VIOLIN,VIOLA,VIOLONCELLOandCONTRABASSarticulation maps carry no tremolo entry, so the note stays on the standard channel. This adds the four tremolo articulations to each of them, on the same bank and program the section variants already use. Those solo maps already take every one of their articulations from that same bank, pizzicato is literally the same program in both, so tremolo was the only one left out. When a soundfont has no such bank, FluidSynth substitutes bank 0 with the same program number before giving up, so a third party font carrying a tremolo preset at program 44 is reached as well.This replaces musescore/MuseScore#30951, which made the same change while the file still lived in the MuseScore repository, where it can no longer be rebased because the path it edits is gone from that tree.