feat(interp): stage-level time-sample evaluator#71
Merged
Conversation
Owner
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USD attributes can carry
timeSamplesbut the crate has had no evaluator for them so far. Anyone wanting a value at a specific stage time had to read the raw samples and interpolate by hand. This PR adds the evaluator so consumers can just ask.Stage::value_at(attr, time)matches C++UsdAttribute::Get(time). It readstimeSamples, picks the bracketing pair, interpolates per the stage's mode, or returns the attribute'sdefaultwhen there are no samples.The behaviour follows AOUSD §12.5:
ValueBlockin the bracketing pair returnsNone.11 unit + 11 integration tests, all green. ROADMAP §12.5.1 and §12.5.2 flip to ✅.
Heads-up: a follow-up PR will add
UsdSkelAnimQueryon top of this — a thin wrapper that pulls aSkelAnimation's translations / rotations / scales throughvalue_atso the existingSkeletonResolver/SkinningResolvercan be driven at a stage time.