Repository navigation
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ca9fd09:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first
Linking.addEventListener('onOpen', callback)registration adds its callback twice, so opening a URL invokes it twice. Removing a listener also compares function source text, which can remove a different callback with the same implementation (such as closures created by a factory).Initialize the listener list empty and remove callbacks by identity in both the subscription and deprecated removal paths. Three regressions cover one notification per registration, independent callbacks with identical source, and the deprecated API. All three fail before the fix.
Validation: complete DOM and Node suites pass (724 tests, 6 existing skips, 220 snapshots); repository formatting and lint checks pass. Flow is not verified locally: its pinned 0.148.0 macOS binary exits with architecture error -86 on this arm64 host. Upstream CI runs the checker on Linux.
AI assistance: OpenAI Codex implemented the fix and regression tests on behalf of @KuroGeo.