-
Notifications
You must be signed in to change notification settings - Fork 18
Add tvOS (Apple TV) support for NetBird VPN client #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shuuri-labs
wants to merge
21
commits into
main
Choose a base branch
from
feat/add-tvos-support-beta
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
413f113
Add tvOS (Apple TV) support for NetBird VPN client
shuuri-labs 8ac8cee
Merge branch 'main' into feat/add-tvos-support-beta
shuuri-labs d4e573f
cleanup
shuuri-labs 2e01447
fixed slow startup + added images
shuuri-labs 7af9d71
fixed active networks not refreshing
shuuri-labs 2b056c3
fix occasional failure of first connection
shuuri-labs 4c79a6c
hostname properly set + removed debug logging
shuuri-labs a75a39d
- Fix "invalid Prefix" display on Networks tab by showing route name
shuuri-labs 7f45512
Fixed focus escape bug on 'change server' dialog
shuuri-labs f3dbbd4
fixed switching of management servers
shuuri-labs 1d7c0d2
fixes for change server settings menu
shuuri-labs 6579821
- Extract TVColors and TVLayout to shared TVColors.swift
shuuri-labs 72acdc1
apply recommended xcode settings
shuuri-labs 2bc4cc3
display correct app name in tvOS UI
shuuri-labs 5592944
added tv-specific assets, updated readme
shuuri-labs 6c1a9d0
updated readme
shuuri-labs 79afaae
- Add checkLoginError IPC to detect extension login failures
shuuri-labs 9466287
integrated changes from main
shuuri-labs a8fa156
Fix CodeRabbit review issues: bundle IDs, force-unwraps, and error ha…
shuuri-labs 3dbe268
- Delete unused updateManagementURL() and setSetupKey() functions
shuuri-labs 71f06dd
Fix tvOS build issues from CodeRabbit review
shuuri-labs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
NetBird TV/Assets.xcassets/AccentColor.colorset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "colors" : [ | ||
| { | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11
...ssets/App Icon - App Store.imagestack/Back.imagestacklayer/Content.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "idiom" : "tv" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
6 changes: 6 additions & 0 deletions
6
...helf Image.brandassets/App Icon - App Store.imagestack/Back.imagestacklayer/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
14 changes: 14 additions & 0 deletions
14
...sets/App Icon & Top Shelf Image.brandassets/App Icon - App Store.imagestack/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| }, | ||
| "layers" : [ | ||
| { | ||
| "filename" : "Middle.imagestacklayer" | ||
| }, | ||
| { | ||
| "filename" : "Back.imagestacklayer" | ||
| } | ||
| ] | ||
| } |
11 changes: 11 additions & 0 deletions
11
...ets/App Icon - App Store.imagestack/Middle.imagestacklayer/Content.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "idiom" : "tv" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
6 changes: 6 additions & 0 deletions
6
...lf Image.brandassets/App Icon - App Store.imagestack/Middle.imagestacklayer/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
17 changes: 17 additions & 0 deletions
17
...Image.brandassets/App Icon.imagestack/Back.imagestacklayer/Content.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "netbird-tvos-icon.png", | ||
| "idiom" : "tv", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "tv", | ||
| "scale" : "2x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Binary file added
BIN
+15.1 KB
...App Icon.imagestack/Back.imagestacklayer/Content.imageset/netbird-tvos-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions
6
...Icon & Top Shelf Image.brandassets/App Icon.imagestack/Back.imagestacklayer/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
17 changes: 17 additions & 0 deletions
17
.../Assets.xcassets/App Icon & Top Shelf Image.brandassets/App Icon.imagestack/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| }, | ||
| "layers" : [ | ||
| { | ||
| "filename" : "Front.imagestacklayer" | ||
| }, | ||
| { | ||
| "filename" : "Middle.imagestacklayer" | ||
| }, | ||
| { | ||
| "filename" : "Back.imagestacklayer" | ||
| } | ||
| ] | ||
| } |
17 changes: 17 additions & 0 deletions
17
...mage.brandassets/App Icon.imagestack/Front.imagestacklayer/Content.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "netbird-tvos-icon.png", | ||
| "idiom" : "tv", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "tv", | ||
| "scale" : "2x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } | ||
Binary file added
BIN
+15.1 KB
...pp Icon.imagestack/Front.imagestacklayer/Content.imageset/netbird-tvos-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions
6
...con & Top Shelf Image.brandassets/App Icon.imagestack/Front.imagestacklayer/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
17 changes: 17 additions & 0 deletions
17
...age.brandassets/App Icon.imagestack/Middle.imagestacklayer/Content.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "netbird-tvos-icon.png", | ||
| "idiom" : "tv", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "tv", | ||
| "scale" : "2x" | ||
| } | ||
|
Comment on lines
+8
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider providing 2x scale icon asset. The 2x scale entry has no filename specified. While the app will function using the 1x asset scaled up, providing a dedicated 2x version would ensure optimal icon quality on higher-resolution tvOS devices. 🤖 Prompt for AI Agents |
||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } | ||
Binary file added
BIN
+15.1 KB
...p Icon.imagestack/Middle.imagestacklayer/Content.imageset/netbird-tvos-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions
6
...on & Top Shelf Image.brandassets/App Icon.imagestack/Middle.imagestacklayer/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
32 changes: 32 additions & 0 deletions
32
NetBird TV/Assets.xcassets/App Icon & Top Shelf Image.brandassets/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "assets" : [ | ||
| { | ||
| "filename" : "App Icon - App Store.imagestack", | ||
| "idiom" : "tv", | ||
| "role" : "primary-app-icon", | ||
| "size" : "1280x768" | ||
| }, | ||
| { | ||
| "filename" : "App Icon.imagestack", | ||
| "idiom" : "tv", | ||
| "role" : "primary-app-icon", | ||
| "size" : "400x240" | ||
| }, | ||
| { | ||
| "filename" : "Top Shelf Image Wide.imageset", | ||
| "idiom" : "tv", | ||
| "role" : "top-shelf-image-wide", | ||
| "size" : "2320x720" | ||
| }, | ||
| { | ||
| "filename" : "Top Shelf Image.imageset", | ||
| "idiom" : "tv", | ||
| "role" : "top-shelf-image", | ||
| "size" : "1920x720" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
16 changes: 16 additions & 0 deletions
16
...assets/App Icon & Top Shelf Image.brandassets/Top Shelf Image Wide.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "idiom" : "tv", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "tv", | ||
| "scale" : "2x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
16 changes: 16 additions & 0 deletions
16
...ts.xcassets/App Icon & Top Shelf Image.brandassets/Top Shelf Image.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "idiom" : "tv", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "tv", | ||
| "scale" : "2x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
23 changes: 23 additions & 0 deletions
23
NetBird TV/Assets.xcassets/icon-netbird-button.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "icon-netbird-button.png", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Binary file added
BIN
+383 Bytes
NetBird TV/Assets.xcassets/icon-netbird-button.imageset/icon-netbird-button.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+584 Bytes
NetBird TV/Assets.xcassets/icon-netbird-button.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+794 Bytes
NetBird TV/Assets.xcassets/icon-netbird-button.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
56 changes: 56 additions & 0 deletions
56
NetBird TV/Assets.xcassets/netbird-logo-menu.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "netbird-logo-menu.png", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| } | ||
| ], | ||
| "filename" : "netbird-logo-menu 1.png", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| } | ||
| ], | ||
| "filename" : "netbird-logo-menu@2x 1.png", | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| } | ||
| ], | ||
| "filename" : "netbird-logo-menu@3x 1.png", | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Binary file added
BIN
+6.81 KB
NetBird TV/Assets.xcassets/netbird-logo-menu.imageset/netbird-logo-menu 1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.62 KB
NetBird TV/Assets.xcassets/netbird-logo-menu.imageset/netbird-logo-menu.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.1 KB
NetBird TV/Assets.xcassets/netbird-logo-menu.imageset/netbird-logo-menu@2x 1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+7.89 KB
NetBird TV/Assets.xcassets/netbird-logo-menu.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+9.37 KB
NetBird TV/Assets.xcassets/netbird-logo-menu.imageset/netbird-logo-menu@3x 1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+6.67 KB
NetBird TV/Assets.xcassets/netbird-logo-menu.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>com.apple.developer.networking.networkextension</key> | ||
| <array> | ||
| <string>packet-tunnel-provider</string> | ||
| </array> | ||
| <key>com.apple.security.application-groups</key> | ||
| <array> | ||
| <string>group.io.netbird.app.tv</string> | ||
| </array> | ||
| </dict> | ||
| </plist> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>com.apple.developer.networking.networkextension</key> | ||
| <array> | ||
| <string>packet-tunnel-provider</string> | ||
| </array> | ||
| <key>com.apple.security.application-groups</key> | ||
| <array> | ||
| <string>group.io.netbird.app.tv</string> | ||
| </array> | ||
| </dict> | ||
| </plist> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider providing 2x scale icon asset.
Similar to the Middle layer, the 2x scale entry has no filename. Providing dedicated 2x versions for all icon layers would ensure optimal quality on higher-resolution displays.
🤖 Prompt for AI Agents