Request API vs IRequest interface #147

Activity

1. xificurk commented on Feb 20, 2019

   

   xificurk

   on Feb 20, 2019

   Author

   More actions

   @dg Any thoughts? I think this needs to be resolved before stable 3.0 version.
2. dg commented on Feb 28, 2019

   

   dg

   on Feb 28, 2019

   Member

   More actions

   For the next version there are plans to move to middleware and there will be probably a lot of changes. So currently I do not want make a BC break and we'll solve it the next time.
3. dg

   added this to the v4.0 milestone on Feb 28, 2019
4. xificurk commented on Feb 28, 2019

   

   xificurk

   on Feb 28, 2019

   Last edited by xificurk

   Author

   More actions

   I really think this needs to be solved now, because of BC break introduced in #90.

   Please, tell me if I'm missing some crucial point. The following code works just fine in Nette 2.4.x:

   class Foo
   {
       /** @var Nette\Http\Request */
       private $request;
    
      public function __construct(Nette\Http\Request $request)
       {
           $this->request = $request;
       }
    
       public function bar(): void
       {
           if ($this->request->isSameSite()) {
               // whatava
           }
       }

   As far as I know, there is no way how to make it work in Nette 3.x. I can't use directly Request type and the IRequest interface does not declare isSameSite() method (and bunch of others).
5. dg commented on Mar 9, 2019

   

   dg

   on Mar 9, 2019

   Member

   More actions

   I reverted fix for #90.

   👍React with 👍1Reacted by Petr Morávek