Skip to content

fix: file system provider#16121

Merged
tobiasKaminsky merged 12 commits intomasterfrom
fix/file-system-provider
Dec 17, 2025
Merged

fix: file system provider#16121
tobiasKaminsky merged 12 commits intomasterfrom
fix/file-system-provider

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Dec 12, 2025

  • Tests written, or not not needed

Issue

FileSyncHelper logged "skipping contentPath" due to wrong timestamp-based checks, causing files to be incorrectly skipped.
Other MediaFolderType not obey auto upload configuration

Changes

Removes ContentResolver, based insert/update logic and migrated to DAO implementation and one single function is used for DB inserts.

Fixes insert logic check for all MediaFolderType

Fixes tests

Removed FileSystemDataSet and moved to directly using FilesystemEntity.


From Auto upload overview page, after selecting recognized directory:

1

Upload starts for that directory:

2

Same process for other directories:

image

Result of DB (as expected, synced folder ID is different for each configured folder ):

image

Next time if same directory scanned:

Screenshot 2025-12-12 at 12 59 25

@alperozturk96 alperozturk96 marked this pull request as draft December 12, 2025 11:10
@alperozturk96 alperozturk96 marked this pull request as ready for review December 12, 2025 11:35
@nextcloud nextcloud deleted a comment from github-actions bot Dec 12, 2025
@nextcloud nextcloud deleted a comment from github-actions bot Dec 12, 2025
@alperozturk96 alperozturk96 force-pushed the fix/file-system-provider branch from 8eb9962 to a8675fe Compare December 12, 2025 13:50
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.35

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/file-system-provider branch from e02b638 to 68474b1 Compare December 15, 2025 08:26
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16121.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@tobiasKaminsky tobiasKaminsky merged commit 48280fb into master Dec 17, 2025
13 of 20 checks passed
@tobiasKaminsky tobiasKaminsky deleted the fix/file-system-provider branch December 17, 2025 09:04
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.36.0 milestone Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants