Feature/governance labels integration#10100
Open
mgallien wants to merge 18 commits into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
from
08ca064 to
1582c09
Compare
github-actions
Bot
dismissed
their stale review
No Clang-Tidy warnings found so I assume my comments were addressed
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
3 times, most recently
from
b830eeb to
67ce384
Compare
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
2 times, most recently
from
9eb43f4 to
53e3bf8
Compare
|
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
4 times, most recently
from
dc9a299 to
7368284
Compare
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
5 times, most recently
from
5ed8302 to
f03b9e7
Compare
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
from
f03b9e7 to
55323d4
Compare
will enable to share type definitions in all real jobs Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
also improve the available properties for the job parameters Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
finish implementing most of the code needed to send requests to the governance API will need further work to see how to read the replies and make something usefull Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should enable us to test the requests one by one and ensure we decode properly the replies Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
we explicitely define which roles need to be used Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Restyle GovernanceLabelsDialog to match the design system used by
AccountWizardWindow and its sub-components in wizard/qml/:
- Set explicit wizard palette and background on the ApplicationWindow
for full light/dark mode support
- Replace stock ComboBox, Button and DialogButtonBox with WizardComboBox
and WizardButton for consistent Nextcloud branding
- Add bold dialog title heading, update margins to 24 px, fix spacing
- Wrap all label strings in qsTr() and apply wizard text colors
- Fix window title typo ("Applys labels" → "Apply labels")
- Add WizardComboBox.qml, a reusable styled combo box following the
WizardButton/WizardTextField component pattern
Assisted-by: ClaudeCode:claude-sonnet-4-6
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should make it easier and more predictable to use from QML Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
the model is responsible to provide data to the UI and manage the set of selected labels by taking UI input and delegating the modifications via emitted signals Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
the item in the combobox have the ability to show if they are selected or not refresh state as soon as one label is selected select a selected one will remove it select an unselected one will apply it selecting none should remove all labels Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
from
55323d4 to
e946e51
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10100.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
|
||
| explicit GovernanceLabelsListModel(QObject *parent = nullptr); | ||
|
|
||
| int rowCount(const QModelIndex &parent = QModelIndex()) const override; |
Contributor
There was a problem hiding this comment.
function rowCount should be marked [[nodiscard]]
Suggested change
| int rowCount(const QModelIndex &parent = QModelIndex()) const override; | |
| [[nodiscard]] int rowCount(const QModelIndex &parent = QModelIndex()) const override; |
|
|
||
| int rowCount(const QModelIndex &parent = QModelIndex()) const override; | ||
|
|
||
| QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; |
Contributor
There was a problem hiding this comment.
function data should be marked [[nodiscard]]
Suggested change
| QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; | |
| [[nodiscard]] QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; |
|
|
||
| QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; | ||
|
|
||
| QHash<int,QByteArray> roleNames() const override; |
Contributor
There was a problem hiding this comment.
function roleNames should be marked [[nodiscard]]
Suggested change
| QHash<int,QByteArray> roleNames() const override; | |
| [[nodiscard]] QHash<int,QByteArray> roleNames() const override; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for opening a pull request on the Nextcloud desktop client.
Before sending a pull request that fixes a security issue please report it via our HackerOne page (https://hackerone.com/nextcloud) following our security policy (https://nextcloud.com/security/).
This allows us to coordinate the fix and release without potentially exposing all Nextcloud client users in the meantime.
Instead of a Contributor License Agreement (CLA) we use a Developer Certificate of Origin (DCO).
https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin
-->
Resolves
#
Close https://github.com/nextcloud-gmbh/server/issues/953
Close https://github.com/nextcloud-gmbh/server/issues/957
Summary
TODO
Checklist
AI (if applicable)