fix(redirect): allow credentials for HTTPS redirects in different domains#10264
Open
Cheekie25 wants to merge 1 commit into
Open
fix(redirect): allow credentials for HTTPS redirects in different domains#10264Cheekie25 wants to merge 1 commit into
Cheekie25 wants to merge 1 commit into
Conversation
…ains This patch improves the redirect credential handling to support legitimate SSO scenarios while maintaining security. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: cheekie <nico183@outlook.fr>
Cheekie25
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
nilsding
reviewed
Jul 8, 2026
Comment on lines
+649
to
+651
| if (const auto trustedRedirectHosts = settings.value(QLatin1String(trustedRedirectHostsC)).toStringList(); !trustedRedirectHosts.isEmpty()) { | ||
| acc->setTrustedRedirectHosts(trustedRedirectHosts); | ||
| } |
Member
There was a problem hiding this comment.
could you explain the reasoning behind this setting?
from what I can tell this list is never updated/set by the client itself, updating the trusted redirect hosts list would require manual modification of the config file while the client is stopped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
10258
Summary
Thanks to this PR, it's now possible to redirect in different domains which is often the case with forward proxy.
Fixes: Regression from commit 585b6ca
Checklist
AI (if applicable)