fix: Don't recursively call processEvents#10314
Merged
Merged
Conversation
Xaymar
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
nilsding
approved these changes
Jul 8, 2026
nilsding
left a comment
nilsding
left a comment
Member
There was a problem hiding this comment.
thanks for your contribution!
mgallien
force-pushed
the
10312-recursive-events
branch
from
81dba5f to
a51523b
Compare
Member
|
/backport to stable-34.0 please |
Calling QCoreApplication::processEvents() causes a recursive re-entrant event loop that will eventually run out of stack space. This should have broken way earlier, but it appears that it went under the radar until a sufficiently fast network and storage is attached. It's unclear why this was even called in the first place - QApplication::exec() already runs the GUI QEventLoop anyway. Fixes nextcloud#10312. Signed-off-by: Xaymar <info@xaymar.com>
mgallien
force-pushed
the
10312-recursive-events
branch
from
a51523b to
22bf46a
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10314.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Fixes #10312
Summary
Removes the re-entrant main QEventLoop handling caused by calling
QCoreApplication::processEvents()which eventually causes a stack overflow. It's unclear what this call was supposed to do as the main QEventLoop is already handled by callingQApplication::exec()which is necessary anyway. This appears to be a remnant of someone not being well versed in asynchronous workloads, though that doesn't appear to be the only issue with the code in question.TODO
Checklist
AI (if applicable)