Conversation
enjeck
force-pushed
the
add-playwright
branch
from
786ec9d to
8f3a4ee
Compare
Member
|
This does not work on CI yet, as there is no Nextcloud server started by default. Those are the relevant bits how we do that in other apps: https://github.com/nextcloud/text/blob/main/playwright.config.ts#L49-L57 |
enjeck
force-pushed
the
add-playwright
branch
4 times, most recently
from
c27bc69 to
02ebc01
Compare
enjeck
force-pushed
the
add-playwright
branch
2 times, most recently
from
c2bc6aa to
274ed14
Compare
enjeck
force-pushed
the
add-playwright
branch
from
83be74e to
274ed14
Compare
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
enjeck
force-pushed
the
add-playwright
branch
from
db6e456 to
fc0d7f1
Compare
juliusknorr
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, we have some basic tests that ensure we at least load the editor and can type. We've had situations in the past where we merged changes that broke the editor but we didn't know because we didn't manually test 🫣🫣🫣. Now, we'll worry less