[local] feat(previews): previews and tests for large remote videos w/o full download#54915
Merged
1 commit merged intomasterfrom Sep 5, 2025
Merged
[local] feat(previews): previews and tests for large remote videos w/o full download#549151 commit merged intomasterfrom
1 commit merged intomasterfrom
Conversation
…ownload Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: invario <67800603+invario@users.noreply.github.com>
artonge
requested review from
ArtificialOwl,
salmart-dev and
sorbaugh
and removed request for
a team
provokateurin
approved these changes
Sep 5, 2025
provokateurin
added
enhancement
3. to review
artonge
force-pushed
the
pr/invario/53952
branch
from
c8069ea to
97a0dde
Compare
auto-merge was automatically disabled
September 5, 2025 08:18
Pull request was closed
Vislike
reviewed
Sep 5, 2025
| // 1 = read an additional 8 bytes after the label to get the 64 bit | ||
| // size of the atom. Needed for large atoms like 'mdat' (the video data) | ||
| if ($atomSize === 1) { | ||
| $atomSize = (int)hexdec(bin2hex(stream_get_contents($content, 8, (int)($offset + 8)))); |
There was a problem hiding this comment.
Just adding it here also after discussion in #53952 possible infinite loop if damaged/maliciously formatted file: the 8 bytes evaluates to 0, making $offset += $atomSize not stepping.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local copy of #53952 for CI
Closes #53469