Open
Conversation
CarlSchwan
requested review from
a team,
ChristophWurst,
SebastianKrupinski and
tcitworld
as code owners
CarlSchwan
requested review from
ArtificialOwl,
come-nc,
icewind1991 and
provokateurin
and removed request for
a team
provokateurin
approved these changes
Feb 6, 2026
CarlSchwan
force-pushed
the
carl/reactor-run
branch
3 times, most recently
from
a4f4c20 to
1ced58a
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/reactor-run
branch
from
1ced58a to
9a22db7
Compare
come-nc
reviewed
Feb 23, 2026
|
|
||
| class File extends Node implements \OCP\Files\File { | ||
| /** | ||
| * Creates a Folder that represents a non-existing path |
Comment on lines
-63
to
+44
| * Creates a Node of the same type that represents a non-existing path | ||
| * Get non existing node. |
Contributor
There was a problem hiding this comment.
Previous description was better 😁
| * @throws \Exception | ||
| */ | ||
| protected function createNonExistingNode($path) { | ||
| protected function createNonExistingNode(string $path): Node { |
Contributor
There was a problem hiding this comment.
Suggested change
| protected function createNonExistingNode(string $path): Node { | |
| protected function createNonExistingNode(string $path): self { |
Should be correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run rector on new code
Checklist
3. to review, feature component)stable32)