fix(config): add null coalescing fallback in getValueBool before strtolower#60654
Open
skjnldsv wants to merge 1 commit into
Open
fix(config): add null coalescing fallback in getValueBool before strtolower#60654skjnldsv wants to merge 1 commit into
skjnldsv wants to merge 1 commit into
Conversation
28fbf8c to
960e92b
Compare
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
CarlSchwan
approved these changes
May 22, 2026
960e92b to
cea3890
Compare
nickvergessen
approved these changes
May 22, 2026
…olower Followup to #59646: guard against null reaching strtolower() in both AppConfig and UserConfig getValueBool(). Also aligns AppConfig with the (string) cast added in UserConfig by the original PR. Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
cea3890 to
b86f463
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Despite having the patch from #59646, a customer is still experiencing the following:
Summary
Followup to #59646: both
AppConfig::getValueBool()andUserConfig::getValueBool()pass the return value ofgetTypedValue()directly tostrtolower(). Although the declared return type isstring, the same OPcache/PHP bug that motivated the(string)cast in UserConfig can cause a null to slip through at runtime.?? 'false'null coalescing fallback inUserConfig::getValueBool()(string)cast, OPcache comment, and?? 'false'fallback inAppConfig::getValueBool(), aligning it with the pattern introduced for UserConfig in fix(UserConfig): cast getTypedValue() result to string in getValueBool() #59646TODO
Checklist
3. to review)AI (if applicable)