perf: Replace more calls from getUserGroups to getUserGroupIds#61904
Open
CarlSchwan wants to merge 2 commits into
Open
perf: Replace more calls from getUserGroups to getUserGroupIds#61904CarlSchwan wants to merge 2 commits into
CarlSchwan wants to merge 2 commits into
Conversation
CarlSchwan
requested review from
Altahrim,
ArtificialOwl,
leftybournes and
salmart-dev
and removed request for
a team
provokateurin
approved these changes
Jul 8, 2026
cristianscheid
approved these changes
Jul 8, 2026
CarlSchwan
force-pushed
the
carl/groups-optimization
branch
2 times, most recently
from
7b3fa5b to
986ce7e
Compare
Faster as we only need the gid and not the full group objects Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/groups-optimization
branch
from
986ce7e to
8dd4c83
Compare
kesselb
reviewed
Jul 10, 2026
Comment on lines
+280
to
+282
| if ($displayName !== null) { | ||
| $info[] = ['id' => $groupId, 'displayname' => $displayName]; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if ($displayName !== null) { | |
| $info[] = ['id' => $groupId, 'displayname' => $displayName]; | |
| } | |
| $info[] = ['id' => $groupId, 'displayname' => $displayName ?? $groupId]; |
Contributor
There was a problem hiding this comment.
What could be a reason for getGroupsObjects to return null as displayname?
The reason for #56533 was that a missing group object (in the store) makes the group assignment invisible. If you omit groups without a display, they are hidden again.
Edge case, but easy to avoid with a fallback to groupId as displayname.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Faster as we only need the gid and not the full group objects
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)