Skip to content

test(db): add regression test for string to text column conversion #61912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
moodyjmz wants to merge 1 commit into
base: master
Choose a base branch
from
+41 −0
Draft

test(db): add regression test for string to text column conversion #61912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions tests/lib/DB/MigratorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,47 @@ public function testColumnCommentsInUpdate(): void {
$this->addToAssertionCount(1);
}

/**
* Changing a populated string column to text maps to VARCHAR2 -> CLOB
* on Oracle, which cannot be altered in-place (ORA-22858). This is what
* core Version34000Date20260318095645 does to oc_jobs.argument.
*/
public function testChangeStringToText(): void {
$startSchema = new Schema([], [], $this->getSchemaConfig());
$table = $startSchema->createTable($this->tableName);
$table->addColumn('id', Types::BIGINT);
$table->addColumn('argument', Types::STRING, [
'notnull' => true,
'length' => 4000,
]);
$table->addIndex(['id'], $this->tableName . '_id');

$migrator = $this->getMigrator();
$migrator->migrate($startSchema);

$shortValue = '{"foo":"bar"}';
$longValue = json_encode(['data' => str_repeat('x', 3900)]);
$this->connection->insert($this->tableName, ['id' => 1, 'argument' => $shortValue]);
$this->connection->insert($this->tableName, ['id' => 2, 'argument' => $longValue]);

$endSchema = new Schema([], [], $this->getSchemaConfig());
$table = $endSchema->createTable($this->tableName);
$table->addColumn('id', Types::BIGINT);
$table->addColumn('argument', Types::TEXT, [
'notnull' => true,
]);
$table->addIndex(['id'], $this->tableName . '_id');

$migrator->migrate($endSchema);

$result = $this->connection->executeQuery(
'SELECT ' . $this->connection->quoteIdentifier('argument')
. ' FROM ' . $this->connection->quoteIdentifier($this->tableName)
. ' ORDER BY ' . $this->connection->quoteIdentifier('id') . ' ASC'
);
$this->assertSame([$shortValue, $longValue], $result->fetchFirstColumn());
}

public function testAddingForeignKey(): void {
$startSchema = new Schema([], [], $this->getSchemaConfig());
$table = $startSchema->createTable($this->tableName);
Expand Down
Loading