Skip to content

🖼️ Show images in message notifications#5909

Open
AndyScherzinger wants to merge 2 commits intomasterfrom
feat/2300/imagesInNotifications
Open

🖼️ Show images in message notifications#5909
AndyScherzinger wants to merge 2 commits intomasterfrom
feat/2300/imagesInNotifications

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Feb 26, 2026

To discuss: Is this "good enough" for a first implementation? what hardening should we add? I remember thinking we only have 2 preview sizes, so using the optimal notification size might be nonesense (or I am wrong with this assumption). Also I tested it with sermo, if the server doesn't provide a preview, the notification just shows the text (tested png vs svg)

🖼️ Screenshots

Screenshot_20260227_002118

🚧 TODO

  • discuss hardening

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Feb 26, 2026
@AndyScherzinger AndyScherzinger added enhancement New feature or request 2. developing Work in progress discussion Being discussed feature: notifications 🔔 labels Feb 26, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/2300/imagesInNotifications branch from b573139 to 280bedb Compare February 27, 2026 00:01
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 27, 2026
Resolves #2300

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the feat/2300/imagesInNotifications branch from 280bedb to d61c875 Compare February 28, 2026 08:49
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5909.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9898
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews discussion Being discussed enhancement New feature or request feature: notifications 🔔

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The ability to preview media such as images in the android notification tray.

1 participant