Repository navigation
[stable35] fix(links): keep purely numeric link targets as strings - #9557
Open
backportbot[bot] wants to merge 1 commit into
Open
backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
Defining the `href` attribute without a `parseHTML` function makes Tiptap's default attribute parsing cast numeric-looking strings to numbers. `isLinkToSelfWithHash` then calls `startsWith` on a number and the editor fails to open documents with links like `[test](12345678901234)` or `[[12345678901234|test]]`. Parse the href with `parseHref` so it always stays a string. This also restores the rewrite of old file-picker links to `/f/<fileId>`. Assisted-by: OpenCode:DeepSeek V4.1 Flash Signed-off-by: upskaling <upskaling@users.noreply.github.com>
backportbot
Bot
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
November 5, 2026 15:55
mejo-
approved these changes
Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #9546