Conversation
vagkaratzas
left a comment
vagkaratzas
left a comment
There was a problem hiding this comment.
Nice, left some comments!
| documentation: https://blast.ncbi.nlm.nih.gov/Blast.cgi?CMD=Web&PAGE_TYPE=Blastdocs | ||
| doi: 10.1016/S0022-2836(05)80360-2 | ||
| licence: ["US-Government-Work"] | ||
| identifier: "" |
There was a problem hiding this comment.
I guess you can add the blast identifier here, since rpsblast is shipped with the main blast container, correct?
There was a problem hiding this comment.
I got the message from nf-core that the blast identifier couldn't be found during the module creation. I have checked the other nf-core modules for blast and any of them have identifier. Where else can I check?
Co-authored-by: Evangelos Karatzas <32259775+vagkaratzas@users.noreply.github.com>
| script "../../../wget/main.nf" | ||
| process { | ||
| """ | ||
| input[0] = [ [id:'smart'], "https://ftp.ncbi.nih.gov/pub/mmdb/cdd/little_endian/Smart_LE.tar.gz" ] |
There was a problem hiding this comment.
Add a comment with expected file size to be downloaded maybe?
|
Awesome! In approval state now, but waiting for the new download module to replace |
|
I am closing this PR as we decided to change strategy after discussion with the nf-core community. The new approach is creating an nf-core module for local-cd-search instead of the rpsblast and cdddownloader. The corresponding branches will be removed and issue 9574 will be updated accordingly. |
3 participants
nf-core/modules pull request
This is a brand new module for rpsblast, a BLAST application that searches a protein query against the conserved domain database (CDD).
PR checklist
Reported in issue #
labelnf-core modules test <MODULE> --profile docker