Fix logs excluded multiple times if referenced multiple times in the config#1695
Open
karensantana wants to merge 2 commits into
Open
Fix logs excluded multiple times if referenced multiple times in the config#1695karensantana wants to merge 2 commits into
karensantana wants to merge 2 commits into
Conversation
github-actions
Bot
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1695 +/- ##
==========================================
+ Coverage 84.99% 85.02% +0.03%
==========================================
Files 104 104
Lines 13579 13590 +11
==========================================
+ Hits 11541 11555 +14
+ Misses 1524 1521 -3
Partials 514 514
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When the same log is referenced in the NGINX config multiple times and included in the exclude logs option in the agent config the log is excluded multiple times. Agent has been modified to prevent excluding an
access_logorerror-logmultiple times if it is referenced multiple times in the NGINX config file.Unit tests covering each scenario have been added.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)