Fix connection reset logic to ensure the old subscribe goroutine is cancelled before a new connection is made#1700
Draft
dhurley wants to merge 1 commit into
Draft
Conversation
… reset logic to ensure the old subscribe goroutine is cancelled before a new connection is made.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1700 +/- ##
=======================================
Coverage 85.00% 85.01%
=======================================
Files 104 104
Lines 13579 13596 +17
=======================================
+ Hits 11543 11558 +15
- Misses 1522 1524 +2
Partials 514 514
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| slog.InfoContext(ctxWithMetadata, "Starting new subscribe stream after connection reset") | ||
| subscribeCtx, cp.subscribeCancel = context.WithCancel(ctxWithMetadata) | ||
| go cp.commandService.Subscribe(subscribeCtx) | ||
| cp.subscribeWg.Add(1) |
There was a problem hiding this comment.
question: Are we missing a cp.subscribeWg.Wait() statement?
|
|
||
| cp.conn = newConnection | ||
|
|
||
| // Wait for the old Subscribe goroutine to fully exit before creating a new one with the new connection. . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)