Skip to content

Conversation

@starlightromero
Copy link

Proposed changes

Problem: The user is unable to set a priorityClassName for control plane pods. This could mean that the scheduler prioritizes other pods which rely on Nginx Gateway Fabric

Solution: Add a field to the Helm Chart to allow the user to set the priorityClassName for control plane pods.

Testing: Ran make lint-helm, make generate-helm-schema, and make generate-helm-docs

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

- Allow setting priorityClassName on control plane pods

@nginx-bot
Copy link

nginx-bot bot commented Nov 29, 2025

Hi @starlightromero! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged.
See Linking a pull request to an issue and our Pull Request Guidelines for more information.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart Relates to helm chart labels Nov 29, 2025
@starlightromero
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@bjee19
Copy link
Contributor

bjee19 commented Dec 1, 2025

Hey @starlightromero, looks like there are still some generated files that weren't updated. When you get the chance, can you run make generate from the project root Makefile just to cover all the bases. Thanks!

@starlightromero
Copy link
Author

@bjee19 I rebased and then ran make generate. No additional files have changed

@bjee19
Copy link
Contributor

bjee19 commented Dec 1, 2025

Oops I'm sorry I gave you the wrong command, could you run make generate-all. That should populate the files in the deploy folder and allow the pipeline to pass. @starlightromero

name: nginx-agent-tls
nodeSelector:
kubernetes.io/os: linux
priorityClassName: null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this deploy okay and be ignored by k8s?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this will not be okay. I can manually update it to an empty string (""). However, does the make command need to be updated as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just make this field conditional in the template, so that it's only rendered if it's specified. That way by default it isn't rendered at all.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Dec 16, 2025
@bjee19
Copy link
Contributor

bjee19 commented Dec 16, 2025

Hey @starlightromero, unfortunately we still have an issue on our side preventing this PR from being merged since its from a fork. We are currently working on getting it fixed, however there still is a comment for review out, so when you get the chance, if you could take a look at that that would be great. Once that gets resolved and this PR is approved, we'll merge it once we fix our issue.

@github-actions github-actions bot removed the stale Pull requests/issues with no activity label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community documentation Improvements or additions to documentation helm-chart Relates to helm chart release-notes

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

3 participants