Skip to content

fix LTS transition handling of generateReleasePlan #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aduh95 wants to merge 2 commits into
base: main
Choose a base branch
from
+64 −49
Open

fix LTS transition handling of generateReleasePlan #1163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7079006
fix LTS transition handling of `generateReleasePlan`
aduh95 Jun 21, 2026
f8dfe26
fixup! fix LTS transition handling of `generateReleasePlan`
aduh95 Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 64 additions & 49 deletions generateReleasePlan.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,69 +2,84 @@

// Generate Release Plan table for a given release line.
// Usage:
// node --harmony-temporal generateReleasePlan.mjs xx
// node generateReleasePlan.mjs xx
// or
// node --harmony-temporal generateReleasePlan.mjs path/to/CHANGELOG_Vxx.md
// node generateReleasePlan.mjs path/to/CHANGELOG_Vxx.md

import { open, readFile } from 'node:fs/promises'
import { open, readFile } from 'node:fs/promises';
const schedule = JSON.parse(await readFile(new URL('./schedule.json', import.meta.url), 'utf-8'));

let [,, version] = process.argv;

console.log(`_Draft schedule - all dates subject to change_
let [, , majorVersion] = process.argv;

const tableHeader = `
Version | Release Date | Releaser(s)
--------|--------------| -------------`);
------- | ------------ | -----------`;
console.log(`_Draft schedule - all dates subject to change_\n${tableHeader}`);

let lastReleaseDate;
if (isNaN(version)) {
const existingReleases = [];
const releaseTitle = /^## (\d{4}-\d{2}-\d{2}), Version (\d+\.\d+\.\d+) ([^,]+), (.+)$/;
const securityRelease = /^This is a security release\.$/;
const fd = await open(version, 'r');
let releaseType
for await (const line of fd.readLines()) {
const releaseTitleMatch = releaseTitle.exec(line);
if (releaseTitleMatch) {
const [, date, version, type, releasers] = releaseTitleMatch;
lastReleaseDate ??= Temporal.PlainDate.from(date);
const versionStr = type === '(Current)' && type !== releaseType ? `${version} (LTS transition)` : version;
existingReleases.unshift(` ${versionStr} | ${date} | ${releasers}`)
releaseType = type;
} else if (securityRelease.test(line)) {
existingReleases[0] = existingReleases[0].replace(/^([^|]+) \|/, "$1 (Security) |");
}
}
console.log(existingReleases.join('\n'))

version = existingReleases[0].slice(1, existingReleases[0].indexOf('.'));
}
const versionKey = `v${version}`;
function outputFutureReleaseSchedule(majorVersion, lastReleaseDate) {
const versionKey = `v${majorVersion}`;

if (!Object.hasOwn(schedule, versionKey)) {
throw new Error(`Unknown version ${version}, accepted values are ${Object.keys(schedule)}`);
}
if (!Object.hasOwn(schedule, versionKey)) {
throw new Error(`Unknown version ${majorVersion}, accepted values are ${Object.keys(schedule)}`);
}

const { start, maintenance, lts } = schedule[versionKey];
const { start, maintenance, lts } = schedule[versionKey];

const ltsDateTime = lts && Temporal.PlainDate.from(lts);
const maintenanceDateTime = Temporal.PlainDate.from(maintenance);
const ltsDateTime = lts && Temporal.PlainDate.from(lts);
const maintenanceDateTime = Temporal.PlainDate.from(maintenance);

const isNowDuringLTS = lts && Temporal.PlainDate.compare(Temporal.Now.plainDateTimeISO(), ltsDateTime) > 0;
const weeks = isNowDuringLTS ? 4 : 2;
const isNowDuringLTS = lts && Temporal.PlainDate.compare(Temporal.Now.plainDateTimeISO(), ltsDateTime) > 0;
const weeks = isNowDuringLTS ? 4 : 2;

const startOfCycle = lastReleaseDate?.add({ weeks }) ?? (isNowDuringLTS ? ltsDateTime : Temporal.PlainDate.from(start));
const endOfCycle = isNowDuringLTS ? maintenanceDateTime : ltsDateTime || maintenanceDateTime;
const startOfCycle =
lastReleaseDate?.add({ weeks }) ?? (isNowDuringLTS ? ltsDateTime : Temporal.PlainDate.from(start));
const endOfCycle = isNowDuringLTS ? maintenanceDateTime : ltsDateTime || maintenanceDateTime;

for (let i = startOfCycle; Temporal.PlainDate.compare(i, endOfCycle) === -1; i = i.add({ weeks })) {
console.log(` ${majorVersion}.x.x | ${i} | `);
}

for (let i = startOfCycle; Temporal.PlainDate.compare(i, endOfCycle) === -1; i = i.add({ weeks })) {
console.log(` ${version}.x.x | ${i} | `);
if (lts && (!lastReleaseDate || Temporal.PlainDate.compare(maintenance, lastReleaseDate) > 0)) {
console.log(
`${majorVersion}.x.x (${isNowDuringLTS ? 'Maintenance' : 'LTS'} transition) | ${
isNowDuringLTS ? maintenance : lts
} | ${isNowDuringLTS ? '_No release_' : ''}`,
);
}
}

if (lts && (!lastReleaseDate || Temporal.PlainDate.compare(maintenance, lastReleaseDate) > 0)) {
console.log(
`${version}.x.x (${isNowDuringLTS ? 'Maintenance' : 'LTS'} transition) | ${
isNowDuringLTS ? maintenance : lts
} | ${isNowDuringLTS ? '_No release_' : ''}`,
);
if (isNaN(majorVersion)) {
let hasOutputFutureScheduleYet = false;
const existingReleases = [];
const releaseTitle = /^## (\d{4}-\d{2}-\d{2}), Version (\d+\.\d+\.\d+) ([^,]+), (.+)$/;
const securityRelease = /^This is a security release\.$/;
const fd = await open(majorVersion, 'r');
let releaseType, lastReleaseDate;
for await (const line of fd.readLines()) {
const releaseTitleMatch = releaseTitle.exec(line);
if (releaseTitleMatch) {
const [, date, version, type, releasers] = releaseTitleMatch;
lastReleaseDate ??= Temporal.PlainDate.from(date);
const wasLTSTransition = releaseType && type === '(Current)' && type !== releaseType;
if (wasLTSTransition) {
const majorVersion = existingReleases[0].slice(1, existingReleases[0].indexOf('.'));
existingReleases[0] = existingReleases[0].replace('|', '(LTS transition) |');
console.log(existingReleases.splice(0, Infinity, '', '</details>').join('\n'));
outputFutureReleaseSchedule(majorVersion, lastReleaseDate);
hasOutputFutureScheduleYet = true;
console.log('\n\n<details><summary>Current</summary>\n\n' + tableHeader);
}
existingReleases.unshift(` ${version} | ${date} | ${releasers}`);
releaseType = type;
} else if (securityRelease.test(line)) {
existingReleases[0] = existingReleases[0].replace('|', '(Security) |');
}
}
console.log(existingReleases.join('\n'));
if (!hasOutputFutureScheduleYet) {
const majorVersion = existingReleases[0].slice(1, existingReleases[0].indexOf('.'));
outputFutureReleaseSchedule(majorVersion, lastReleaseDate);
}
} else {
outputFutureReleaseSchedule(majorVersion);
}