Skip to content

Add String::New overload for string_view #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cacharle wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add String::New overload for string_view #1706

cacharle wants to merge 2 commits into from
+35 −0

Conversation

@cacharle
Copy link

@cacharle cacharle commented Jan 30, 2026

Fixes #1703

@cacharle
Copy link
Author

cacharle commented Jan 30, 2026

I added the New overload for Symbol aswell. I looked at other functions that take const char* but there is way too many of them and I don't want to unnecessarily bloat the code / break something so let me know if there is other place which could benefit from this overload

@cacharle cacharle marked this pull request as ready for review February 1, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

Node-API Team Project
Status: Need Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add String::New for std::string_view

1 participant

@cacharle