Skip to content

test: fix undici 8.7.0 compatibility #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
legendecas wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −0
Open

test: fix undici 8.7.0 compatibility #3345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1a997d
test: fix undici 8.7.0 compatibility
legendecas Jul 9, 2026
28bb97b
chore: add 30m timeout to test jobs
legendecas Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ jobs:
test-pack:
name: Test Pack
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout Repository
uses: actions/checkout@v7
Expand Down Expand Up @@ -111,6 +112,7 @@ jobs:
node: 26.x
name: ${{ matrix.os }} - ${{ matrix.python }} - ${{ matrix.node }}
runs-on: ${{ matrix.os }}
timeout-minutes: 30
env:
WASI_VERSION: '25'
WASI_VERSION_FULL: '25.0'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/visual-studio.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
- os: windows-11-arm
msvs-version: 2022 # Fix this when Visual Studio 2025 is released

@cclauss cclauss Jul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/runner-images#14017

Customers needing Visual Studio 2022 must migrate to the windows-2022 image.

https://github.com/actions/runner-images/tree/main/images/windows
https://github.com/actions/runner-images/tree/main#available-images

@legendecas legendecas Jul 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows-11-arm is still vs 2022: https://github.com/actions/runner-images/blob/main/images/windows/Windows11-Arm64-Readme.md#visual-studio-enterprise-2022

runs-on: ${{ matrix.os }}
timeout-minutes: 30
steps:
- name: Checkout Repository
uses: actions/checkout@v7
Expand Down
18 changes: 18 additions & 0 deletions test/test-download.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,24 @@ describe('download', function () {

let proxyUsed = false
const pserver = http.createServer()
// undici tunnels https requests through the proxy with CONNECT, but forwards
// plain http requests to the proxy in absolute-form. Handle both so the test
// works regardless of which path undici picks.
pserver.on('request', (creq, cres) => {
proxyUsed = true
const target = new URL(creq.url)
const proxyReq = http.request({
host: target.hostname,
port: target.port,
path: target.pathname + target.search,
method: creq.method,
headers: creq.headers
}, (proxyRes) => {
cres.writeHead(proxyRes.statusCode, proxyRes.headers)
proxyRes.pipe(cres)
})
creq.pipe(proxyReq)
})
pserver.on('connect', (req, clientSocket, head) => {
proxyUsed = true
const [targetHost, targetPort] = req.url.split(':')
Expand Down
Loading