docs: document ALPNCallback option for TLSSocket constructor #61331
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
avivkeller
approved these changes
Jan 10, 2026
avivkeller
added
the
author ready
cjihrig
approved these changes
Jan 10, 2026
avivkeller
added
the
commit-queue
lpinca
approved these changes
Jan 11, 2026
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61331 ✔ Done loading data for nodejs/node/pull/61331 ----------------------------------- PR info ------------------------------------ Title docs: document ALPNCallback option for TLSSocket constructor (#61331) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ikeyan:ikeyan-patch-1 -> nodejs:main Labels tls, doc, author ready Commits 1 - docs: document ALPNCallback option for TLSSocket constructor Committers 1 - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/61331 Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61331 Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 10 Jan 2026 04:36:05 GMT ✔ Approvals: 3 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/61331#pullrequestreview-3646752264 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61331#pullrequestreview-3647121034 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61331#pullrequestreview-3648390625 ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/20908411337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrect #61052 that was closed for unknown reason
Fixes #61047