Skip to content

fs: cache context lookup in vectored io loops #61387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mertcanaltin wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −4
Open

fs: cache context lookup in vectored io loops #61387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe4be58
fs: cache context lookup in vectored io loops
mertcanaltin Jan 14, 2026
77c67fd
update context usage in WriteBuffers and ReadBuffers functions
mertcanaltin Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/node_realm-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

#include "node_context_data.h"
#include "node_realm.h"
#include "util-inl.h"

namespace node {

Expand Down Expand Up @@ -46,6 +47,10 @@ inline v8::Isolate* Realm::isolate() const {
return isolate_;
}

inline v8::Local<v8::Context> Realm::context() const {
return PersistentToLocal::Strong(context_);
}

inline Realm::Kind Realm::kind() const {
return kind_;
}
Expand Down
4 changes: 0 additions & 4 deletions src/node_realm.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,10 +295,6 @@ void Realm::VerifyNoStrongBaseObjects() {
});
}

v8::Local<v8::Context> Realm::context() const {
return PersistentToLocal::Strong(context_);
}

// Per-realm strong value accessors. The per-realm values should avoid being
// accessed across realms.
#define V(PropertyName, TypeName) \
Expand Down
Loading