Skip to content

lib: Fix infinite loop on paths with nested links #61391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mattskel wants to merge 2 commits into
base: main
Choose a base branch
from
Open

lib: Fix infinite loop on paths with nested links #61391

mattskel wants to merge 2 commits into from

Conversation

@mattskel
Copy link

@mattskel mattskel commented Jan 15, 2026

Fixes #60295

@mattskel
lib: fix infinite loop in fs.realpathSync
2914f1e 
Get the link target head realpath.
Then resolve realpath and link target tail.
Resolve tail after resolving the link head.
Fixes: nodejs#60295
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jan 15, 2026
@mattskel mattskel marked this pull request as ready for review January 15, 2026 13:14
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (2679b62) to head (2914f1e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61391      +/-   ##
==========================================
+ Coverage   88.52%   88.54%   +0.02%     
==========================================
  Files         704      704              
  Lines      208796   208819      +23     
  Branches    40312    40324      +12     
==========================================
+ Hits       184828   184891      +63     
+ Misses      15955    15908      -47     
- Partials     8013     8020       +7
Files with missing lines Coverage Δ
lib/fs.js 98.20% <100.00%> (+0.01%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@targos
Copy link
Member

targos commented Jan 16, 2026

Please add a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs.realpath infinite loop

3 participants

@mattskel @targos @nodejs-github-bot