Skip to content

tools: move Quic dependencies behind ad-hoc flag #61446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aduh95 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tools: move Quic dependencies behind ad-hoc flag #61446

aduh95 wants to merge 1 commit into from

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 19, 2026 •
edited
Loading

Refs: 853277a

@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jan 19, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 19, 2026

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 19, 2026
@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label Jan 19, 2026
@avivkeller avivkeller added the blocked PRs that are blocked by other issues or PRs. label Jan 19, 2026
@richardlau
Copy link
Member

richardlau commented Jan 20, 2026

c1277d6 is from #61444, which should land first. Taking it to a separate PR as we can't backport Nix changes further than v25.x.

AFAIK the quic stuff has been mostly labelled dont-land-on-v24.x and earlier.

@targos
Copy link
Member

targos commented Jan 20, 2026

I was happy to see #61444 because QUIC has become a burden to maintain because of the lack of proper maintainers (at least to me because I had to fix things in it while I don't care about it).

This will make it worse as we will only see issues (and have to fix them) in GitHub CI.

@targos
Copy link
Member

targos commented Jan 20, 2026

My opinion is that while a feature is so much experimental (or unmaintained) that it has to be behind a build flag, we shouldn't put the burden of keeping it working to every contributor.

@aduh95
Copy link
Contributor Author

aduh95 commented Jan 20, 2026

I wouldn't mind having the experimental removed from CI if we need to break it, it seems useful to be aware of when that happens though. In any case, I would still like to land the Nix changes marking QUIC deps as disabled by default.

@aduh95
tools: move Quic dependencies behind ad-hoc flag
86460e0 
Quic is now behind `--experimental-quic` build flag, its dependencies
should be included only if the user opts-in.
@aduh95 aduh95 force-pushed the quic-compile-time-flag branch from 88e8ed0 to 86460e0 Compare January 21, 2026 21:49
@aduh95 aduh95 changed the title tools: test building with --experimental-quic tools: move Quic dependencies behind ad-hoc flag Jan 21, 2026
@aduh95 aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Jan 21, 2026
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 21, 2026

Removed the test coverage since there was no consensus on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95 @nodejs-github-bot @richardlau @targos @avivkeller