build,deps: replace cjs-module-lexer with merve

[anonrig]

Initially started a couple of years ago, the new cjs module lexer is 25% faster for cold importing cjs files. This change introduces a new dependency and removes the old one.

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1784/console

                                                                                                                                                                confidence improvement accuracy (*)
esm/detect-esm-syntax.js n=10000 type='with-package-json'                                                                                                              ***      1.47 %       ±0.40%
esm/detect-esm-syntax.js n=10000 type='without-package-json'                                                                                                           ***      0.64 %       ±0.35%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/non-exist' packageConfigMain='./index.js' packageJsonUrl='node_modules/test/package.json' n=10000                *      0.95 %       ±0.92%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/non-exist' packageConfigMain='' packageJsonUrl='node_modules/test/package.json' n=10000                                -0.06 %       ±0.95%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.js' packageConfigMain='./index.js' packageJsonUrl='node_modules/test/package.json' n=10000                  -0.72 %       ±1.02%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.js' packageConfigMain='' packageJsonUrl='node_modules/test/package.json' n=10000                             0.33 %       ±0.62%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.json' packageConfigMain='./index.js' packageJsonUrl='node_modules/test/package.json' n=10000                 0.38 %       ±0.98%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.json' packageConfigMain='' packageJsonUrl='node_modules/test/package.json' n=10000                   **      0.84 %       ±0.61%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.node' packageConfigMain='./index.js' packageJsonUrl='node_modules/test/package.json' n=10000                 0.66 %       ±1.04%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.node' packageConfigMain='' packageJsonUrl='node_modules/test/package.json' n=10000                           0.21 %       ±0.92%
esm/esm-loader-defaultResolve.js specifier='./relative-existing.js' n=1000                                                                                                     -1.93 %       ±5.48%
esm/esm-loader-defaultResolve.js specifier='./relative-nonexistent.js' n=1000                                                                                                  -0.48 %       ±1.94%
esm/esm-loader-defaultResolve.js specifier='node:os' n=1000                                                                                                                    -8.43 %       ±9.28%
esm/esm-loader-defaultResolve.js specifier='node:prefixed-nonexistent' n=1000                                                                                                  -8.48 %      ±10.15%
esm/esm-loader-defaultResolve.js specifier='unprefixed-existing' n=1000                                                                                                         0.56 %       ±3.21%
esm/esm-loader-defaultResolve.js specifier='unprefixed-nonexistent' n=1000                                                                                                     -0.08 %       ±1.73%
esm/esm-loader-import.js specifier='./relative-existing.js' n=1000                                                                                                       *      5.62 %       ±5.09%
esm/esm-loader-import.js specifier='./relative-nonexistent.js' n=1000                                                                                                           1.53 %       ±2.90%
esm/esm-loader-import.js specifier='data:text/javascript,{i}' n=1000                                                                                                            1.47 %       ±2.73%
esm/esm-loader-import.js specifier='node:os' n=1000                                                                                                                             0.43 %       ±7.59%
esm/esm-loader-import.js specifier='node:prefixed-nonexistent' n=1000                                                                                                           2.29 %       ±3.67%
esm/import-cjs.js type='cold'                                                                                                                                          ***     26.83 %       ±0.58%
esm/import-cjs.js type='warm'                                                                                                                                          ***     11.95 %       ±0.14%
esm/import-esm-reload.js n=1000 count=1                                                                                                                                         0.08 %       ±1.04%
esm/import-esm-reload.js n=1000 count=100                                                                                                                                *      0.99 %       ±0.92%
esm/import-meta.js valuesToRead='dirname-and-filename' n=1000                                                                                                           **      1.11 %       ±0.75%
esm/import-meta.js valuesToRead='dirname' n=1000                                                                                                                                0.50 %       ±0.67%
esm/import-meta.js valuesToRead='filename' n=1000                                                                                                                       **      1.17 %       ±0.76%
esm/import-meta.js valuesToRead='url' n=1000                                                                                                                                   -0.57 %       ±0.77%
esm/require-esm.js n=1000 exports='default' type='access'                                                                                                                       0.77 %       ±1.21%
esm/require-esm.js n=1000 exports='default' type='all'                                                                                                                          1.31 %       ±1.75%
esm/require-esm.js n=1000 exports='default' type='load'                                                                                                                         0.06 %       ±1.96%
esm/require-esm.js n=1000 exports='named' type='access'                                                                                                                         0.79 %       ±1.05%
esm/require-esm.js n=1000 exports='named' type='all'                                                                                                                           -0.54 %       ±1.98%
esm/require-esm.js n=1000 exports='named' type='load'                                                                                                                          -0.90 %       ±2.32%

[nodejs-github-bot]

Review requested:

• @nodejs/gyp
• @nodejs/security-wg

[codecov]

Codecov Report

❌ Patch coverage is 78.84615% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.86%. Comparing base (98d2331) to head (b2ec704).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_cjs_lexer.cc	77.55%	8 Missing and 3 partials ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #61456    +/-   ##
========================================
  Coverage   89.85%   89.86%            
========================================
  Files         671      672     +1     
  Lines      203166   203322   +156     
  Branches    39057    39085    +28     
========================================
+ Hits       182554   182713   +159     
+ Misses      12967    12940    -27     
- Partials     7645     7669    +24     

Files with missing lines	Coverage Δ
lib/internal/modules/esm/translators.js	92.58% <100.00%> (-0.39%)	⬇️
src/node_binding.cc	82.74% <ø> (ø)
src/node_builtins.cc	75.95% <ø> (-0.24%)	⬇️
src/node_metadata.cc	92.42% <100.00%> (ø)
src/node_cjs_lexer.cc	77.55% <77.55%> (ø)

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

Where does this new dep live?

[anonrig]

Where does this new dep live?

Currently, under my github account. Is anybody interested in helping me maintain it? github.com/anonrig/merve

[guybedford]

Per current process it would make sense to move merve into the Node.js org as well. I can then add a note to the cjs-module-lexer readme that future bugs should be posted there. I'd value also having permissions to the new repo to continue to provide support.

[lemire]

Next step, name a library after your cat.