Skip to content

build: add cargo and rustc checks for Temporal #61467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
richardlau wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: add cargo and rustc checks for Temporal #61467

richardlau wants to merge 1 commit into from
+62 −0

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Jan 22, 2026

If opting into building Node.js with statically linked Temporal (configure --v8-enable-temporal-support), check for the presence of cargo and rustc and compare the detected versions against the documented toolchain versions in BUILDING.md.

Refs: #60942

@richardlau
build: add cargo and rustc checks for Temporal
279634a 
If opting into building Node.js with statically linked Temporal
(`configure --v8-enable-temporal-support`), check for the presence
of `cargo` and `rustc` and compare the detected versions against the
documented toolchain versions in `BUILDING.md`.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 22, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 22, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70955/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 22, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70956/

juanarbol
juanarbol approved these changes Jan 22, 2026
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Lgtm

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 22, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70957/

@richardlau richardlau added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. labels Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanarbol juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@richardlau @nodejs-github-bot @juanarbol