Skip to content

Conversation

@panva
Copy link
Member

@panva panva commented Feb 1, 2026

This removes DOMException specific wpt subset that is now included in the whole webidl run (added in #61316).

This fixes a wpt.fyi processing issue which marks our runs as invalid

image
Conflicting '/webidl/ecmascript-binding/es-exceptions/DOMException-constants.any.html' found in the merged report (['gs://wptd-results-buffer/nodejs/60fc8a1b-ed23-4b89-9d73-1bc9cd1e00b0/0.json'])

Refs: #61316 (comment)

@panva panva requested a review from anonrig February 1, 2026 15:41
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 1, 2026
@nodejs-github-bot
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (37e4004) to head (18b0c58).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61617      +/-   ##
==========================================
- Coverage   89.78%   89.74%   -0.04%     
==========================================
  Files         673      673              
  Lines      203775   203945     +170     
  Branches    39166    39190      +24     
==========================================
+ Hits       182956   183030      +74     
- Misses      13139    13239     +100     
+ Partials     7680     7676       -4     

see 62 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2026
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants