Draft
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
RafaelGSS
reviewed
Mar 5, 2026
|
|
||
| #### Platform support | ||
|
|
||
| At `./configure` time, Node.js checks for a working `dtrace` tool and |
Member
There was a problem hiding this comment.
We have removed dtrace support long time ago. Wouldn't it require us to include a new suite for testing it on that environment?
Member
Author
There was a problem hiding this comment.
I'm not sure what our build setup looks like now, but yes, everything that was required for the previous incarnation of probes in Node.js would likely be required again with this PR.
Member
There was a problem hiding this comment.
I don't think we tested the dtrace stuff previously. I think when it was removed it had be broken for a while (or maybe that was one of the other non-tested removed features).
Adds USDT probes that are fired for every diagnostics_channel publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds USDT probes that are fired for every diagnostics_channel publish.