doc: document valid_from and valid_to date format in tls#62127
Open
zerone0x wants to merge 1 commit intonodejs:mainfrom
Open
doc: document valid_from and valid_to date format in tls#62127zerone0x wants to merge 1 commit intonodejs:mainfrom
zerone0x wants to merge 1 commit intonodejs:mainfrom
Conversation
Clarify that the valid_from and valid_to fields in the certificate object use the format 'MMM DD HH:MM:SS YYYY GMT' as produced by OpenSSL's ASN1_TIME_print. Fixes: nodejs#56462 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
valid_fromandvalid_tofields in the certificate objectreturned by
tlsSocket.getPeerCertificate()are documented asstrings but their format was unspecified, making it hard to parse
them programmatically.
Clarify that these use the format
'MMM DD HH:MM:SS YYYY GMT'asproduced by OpenSSL's
ASN1_TIME_print, and link to the OpenSSLdocumentation.
Fixes: #56462