Skip to content

tools: make v8.nix more stable#62508

Open
aduh95 wants to merge 4 commits intonodejs:mainfrom
aduh95:stable-v8.nix
Open

tools: make v8.nix more stable#62508
aduh95 wants to merge 4 commits intonodejs:mainfrom
aduh95:stable-v8.nix

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Mar 30, 2026

If we only pass to the V8 builders the dependencies it actually needs, we can avoid rebuilding the same version of V8 just because an unrelated Node.js dependency has been updated.
It also fixes an oversight of the current version which would fail to build if any of the shared lib is disabled.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Mar 30, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.83%. Comparing base (cd391b5) to head (731953b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62508      +/-   ##
==========================================
- Coverage   89.71%   88.83%   -0.88%     
==========================================
  Files         694      694              
  Lines      214245   214245              
  Branches    41119    41027      -92     
==========================================
- Hits       192211   190331    -1880     
- Misses      14109    15929    +1820     
- Partials     7925     7985      +60     

see 103 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label Mar 30, 2026
aduh95 added 4 commits March 31, 2026 19:26
If we only pass to the V8 builders the dependencies it actually needs,
we can avoid rebuilding the same version of V8 just because an unrelated
Node.js dependency has been updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants