Skip to content

tools: align Bash snippets in GHA with lint-sh conventions#63829

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:lint-sh-gha
Jun 12, 2026
Merged

tools: align Bash snippets in GHA with lint-sh conventions#63829
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:lint-sh-gha

Conversation

@aduh95

@aduh95 aduh95 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Our shell scripts enforce passing arbitrary values via quoted env variables to avoid injections.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 10, 2026
Our shell scripts enforce passing arbitrary values via
quoted env variables to avoid injections.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 10, 2026
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2026
@nodejs-github-bot nodejs-github-bot merged commit 144f795 into nodejs:main Jun 12, 2026
21 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 144f795

@aduh95 aduh95 deleted the lint-sh-gha branch June 12, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants