fs: add windowsHandle option to file streams#63851
Open
PickBas wants to merge 2 commits into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Fixes: nodejs#57288 Signed-off-by: PickBas <sayed.kirill@gmail.com>
addaleax
reviewed
Jun 11, 2026
| } | ||
|
|
||
| intptr_t value = | ||
| static_cast<intptr_t>(args[0].As<Number>()->Value()); |
Member
There was a problem hiding this comment.
There's no inherent guarantee that a value that can be represented as an intptr_t or HANDLE can also be represented losslessly as a JS number – if there is some Windows-specific additional guarantee I'm not aware of, it would be very helpful to add a comment about that here, and otherwise, it would probably be a good idea to just use JS bigint instead
Signed-off-by: PickBas <sayed.kirill@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, a value passed as
fdtofs.createReadStream()/fs.createWriteStream()is treated as a CRT file descriptor. When the value is actually a raw Win32HANDLE, for example an inherited anonymous pipe handle received from another process, it fails withEBADF, since libuv operates on CRT file descriptors.This adds a
windowsHandleoption to both stream constructors that wraps the HANDLE in a CRT file descriptor via_open_osfhandle(), so the stream can read from or write to it normally.Fixes: #57288