src,dns: reserve vector capacity to avoid unnecessary reallocations - #64763
Open
agape1225 wants to merge 2 commits into
Open
src,dns: reserve vector capacity to avoid unnecessary reallocations#64763agape1225 wants to merge 2 commits into
agape1225 wants to merge 2 commits into
Conversation
The array_buffers vector's upper bound is known before the loop starts (transfer_list_v.length()), so reserve the capacity upfront to avoid unnecessary reallocations. Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
The chunks vector's upper bound is known before the loop starts (str_count from ares_dns_rr_get_abin_cnt), so reserve the capacity upfront to avoid unnecessary reallocations. Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64763 +/- ##
==========================================
- Coverage 90.15% 90.13% -0.02%
==========================================
Files 744 744
Lines 242517 242519 +2
Branches 45688 45695 +7
==========================================
- Hits 218642 218600 -42
- Misses 15358 15410 +52
+ Partials 8517 8509 -8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Message::Serialize()andParseTxtReply()both grow aLocalVectorvia repeated
push_back()without reserving capacity first, eventhough the upper bound on the number of elements is known before the
loop starts. This adds
reserve()in both places, following theusual idiom of reserving upfront when the size (or a bound on it) is
already known, to avoid the repeated allocate/copy/free cycle that
happens each time capacity is exceeded.
Note: in
Message::Serialize,transfer_list_v.length()is an upperbound rather than an exact count (only
ArrayBufferentries getpushed into
array_buffers), so a transfer list with few or noArrayBuffers reserves capacity that ends up unused. No functional
change either way.